MUD Coding

Samson · 10-23-2002, 06:57 AM

Hey, lookie what I found while scouring code, a genuine bug that nobody seems to have addressed yet!

act_wiz.c, do_vsearch:

if (argi<0 && argi>20000)
{
send_to_char( "Vnum out of range.\n\r", ch);
return;
}

See the problem? argi cannot be BOTH less than 0 AND greater than 20000, so this check will always drop through to the code below. Simple fix. Change the && to || and recompile. Of course you'll also want to make sure that 20000 is an appropriate upper bounds for your mud.

This appears to be present in 1.02a, 1.4a, and every other derivitive I've been able to find. Apparently such an obscure command nobody ever noticed it before.

Smaug bug - Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Looking for new and exp. players - SMAUG MUD	Greetmir	Advertising for Players	0	04-29-2005 11:39 AM
Chronicles/Smaug Mud	CTA	Advertising for Staff	0	05-16-2003 11:15 PM
SSET in SMAUG	Nostrum	Newbie Help	6	08-05-2002 06:03 PM
smaug	Blank Deed	Newbie Help	3	07-24-2002 11:19 AM
Smaug Code Help Please	Klered	MUD Coding	2	07-12-2002 09:42 PM

10-23-2002, 06:57 AM	#1
Samson Member Join Date: Apr 2002 Location: United Socialist States of America Home MUD: SmaugMuds.org Home MUD: Arthmoor MUD Hosting Posts: 249	Hey, lookie what I found while scouring code, a genuine bug that nobody seems to have addressed yet! act_wiz.c, do_vsearch: if (argi<0 && argi>20000) { send_to_char( "Vnum out of range.\n\r", ch); return; } See the problem? argi cannot be BOTH less than 0 AND greater than 20000, so this check will always drop through to the code below. Simple fix. Change the && to \|\| and recompile. Of course you'll also want to make sure that 20000 is an appropriate upper bounds for your mud. This appears to be present in 1.02a, 1.4a, and every other derivitive I've been able to find. Apparently such an obscure command nobody ever noticed it before.

MUD Coding

Smaug bug