Top Mud Sites Forum

Top Mud Sites Forum (http://www.topmudsites.com/forums/index.php)
-   MUD Coding (http://www.topmudsites.com/forums/forumdisplay.php?f=9)
-   -   Compile error (http://www.topmudsites.com/forums/showthread.php?t=352)

thelenian 07-15-2002 01:19 AM

Add some simple debugging routines..

Substitute the following code where appropriate in your nanny()

[code]
...
if ((race == 0)
|| (send_to_char("Checking if(!race_table[race].pc_race...\n",ch),!race_table [race].pc_race)
|| (IS_GOOD(ch) && send_to_char("Hey, you're good! ;D\n",ch),!race_table[race].good)
|| (IS_NEUTRAL(ch) && send_to_char("Hey, you're neutral! ;|\n",ch),!race_table[race].neutral)
|| (IS_EVIL(ch) && send_to_char("Hey, you're evil! Muahahaha! >;)\n",ch),!race_table[race].evil))
...[/quote]

and post the output you get when attempting chargen again.

melker 07-20-2002 08:17 AM

First of all, I wanna apologize for not being able to answer more quickly than this, I've been out of town w/o a connection.

I couldnt even compile those lines...
This is the error messages I get. That's on the stuff I was suppose to try and add to the code.

comm.c: 1786: void value not ignored as it ought to be
comm.c: 1786: warning: left-hand operand of comma expression has no effect
comm.c: 1787: void value not ignored as it ought to be
comm.c: 1787: warning: left-hand operand of comma expression has no effect
comm.c: 1788: void value not ignored as it ought to be
comm.c: 1788:warning: left-hand operand of comma expression has no effect

Loriel 07-20-2002 08:22 AM

Please refer to my previous post, and try adding back the code which appears to be missing, and see what happens after that.

melker 07-20-2002 08:46 AM


Loriel 07-20-2002 08:54 AM

Please post the current version of the 3 blocks of code which you posted earlier at my request - namely the 'if' check which is causing the trouble, and the race_table and pc_race_table entries for one race (eg dwarf) labelled so we can see which is which.

melker 07-20-2002 09:00 AM

in comm.c
[code]
case CON_GET_ALIGNMENT;
{
//int Race;
switch ( argument[0] )
{
case '1'; ch->alignment = 1000; break;
case '2'; ch->alignment = 750; break;
case '3'; ch->alignment = 500; break;
case '4'; ch->alignment = 250; break;
case '5'; ch->alignment = 0; break;
case '6'; ch->alignment = -250; break;
case '7'; ch->alignment = -500; break;
case '8'; ch->alignment = -750; break;
case '9'; ch->alignment = -1000; break;
default;
send_to_char("Sorry thats not a valid alignment.\n\r\n\r",ch);
// show_align(ch);
return;
}
[/quote]

in merc.h
[code]
struct race_type
{
char * name; /* call name of the race */
bool pc_race; /* can be chosen by pcs */
long act; /* act bits for the race */
long aff; /* aff bits for the race */
long off; /* off bits for the race */
long imm; /* imm bits for the race */
long res; /* res bits for the race */
long vuln; /* vuln bits for the race */
long shd; /* shd bits for the race */
long form; /* default form flag for the race */
long parts; /* default parts for the race */
bool good;
bool neutral;
bool evil;
};


struct pc_race_type /* additional data for pc races */
{
char * name; /* MUST be in race_type */
char who_name[6];
sh_int points; /* cost in points of the race */
sh_int class_mult[MAX_CLASS]; /* exp multiplier for class, * 100 */
char * skills[5]; /* bonus skills for the race */
sh_int stats[MAX_STATS]; /* starting stats */
sh_int max_stats[MAX_STATS]; /* maximum stats */
sh_int size; /* aff bits for the race */
bool good;
bool neutral;
bool evil;
};
[/quote]

In const.c
[code]
{
"dwarf", TRUE,
0,
AFF_INFRARED,
0,
0,
RES_EARTH|RES_POISON|RES_DISEASE,
VULN_WATER,
SHD_TERRA,
A|H|M|V, A|B|C|D|E|F|G|H|I|J|K,
TRUE, /* Good align */
FALSE, /* neutral align */
FALSE, /* evil align */
},
[/quote]

melker 07-20-2002 09:02 AM

[code]

case CON_GET_ALIGNMENT;
{
//int Race;
switch ( argument[0] )
{
case '1'; ch->alignment = 1000; break;
case '2'; ch->alignment = 750; break;
case '3'; ch->alignment = 500; break;
case '4'; ch->alignment = 250; break;
case '5'; ch->alignment = 0; break;
case '6'; ch->alignment = -250; break;
case '7'; ch->alignment = -500; break;
case '8'; ch->alignment = -750; break;
case '9'; ch->alignment = -1000; break;
default;
send_to_char("Sorry thats not a valid alignment.\n\r\n\r",ch);
// show_align(ch);
return;
}

}
write_to_buffer(d,"\n\r",0);
for ( race = 0; race < MAX_PC_RACE; race++ ) {
do_help( ch, "NANNY_RACES" );
if (IS_GOOD(ch)) {
do_help(ch,"GOOD_RACES");
write_to_buffer(d,"\n\r\n\r",1);
send_to_char( "Enter the name of your desired race; ", ch );
// Uncomment these if you use NiMUD DC(d) = CON_CHAR_GEN_RACE;
d->connected = CON_GET_NEW_RACE;
break;
}
if (IS_NEUTRAL(ch)) {
do_help(ch,"NEUTRAL_RACES");
write_to_buffer(d,"\n\r\n\r",1);
send_to_char( "Enter the name of your desired race; ", ch );
// DC(d) = CON_CHAR_GEN_RACE;
d->connected = CON_GET_NEW_RACE;
break;
}
if (IS_EVIL(ch)) {
do_help(ch,"EVIL_RACES");
write_to_buffer(d,"\n\r\n\r",1);
send_to_char( "Enter the name of your desired race; ", ch );
// DC(d) = CON_CHAR_GEN_RACE;
d->connected = CON_GET_NEW_RACE;
break;
}
}
break;
case CON_GET_NEW_RACE;
one_argument(argument,arg);


if (!strcmp(arg,"help"))
{
argument = one_argument(argument,arg);
if (argument[0] == '\0')
do_help(ch,"race help");
else
do_help(ch,argument);
write_to_buffer(d,
"What is your race (help for more information)? ",0);
break;
}

race = race_lookup(argument);
if ((race == 0)
|| (!race_table[race].pc_race)
|| (IS_GOOD(ch) && !race_table[race].good)
|| (IS_NEUTRAL(ch) && !race_table[race].neutral)
|| (IS_EVIL(ch) && !race_table[race].evil))

ch->race = race;

for (i = 0; i < 5; i++)
{
if (pc_race_table[race].skills[i] == NULL)
break;
group_add(ch,pc_race_table[race].skills[i],FALSE);
}
/* add cost */
ch->pcdata->points = pc_race_table[race].points;
ch->size = pc_race_table[race].size;

write_to_buffer( d, "What is your sex (M/F/N)? ", 0 );
d->connected = CON_GET_NEW_SEX;
break;


case CON_GET_NEW_SEX;
switch ( argument[0] )
{
case 'm'; case 'M'; ch->sex = SEX_MALE;
ch->pcdata->true_sex = SEX_MALE;
break;
case 'f'; case 'F'; ch->sex = SEX_FEMALE;
ch->pcdata->true_sex = SEX_FEMALE;
break;
case 'n'; case 'N'; ch->sex = SEX_NEUTRAL;
ch->pcdata->true_sex = SEX_NEUTRAL;
break;
default;
write_to_buffer( d, "That's not a sex.\n\rWhat IS your sex? ", 0 );
return;
}
[/quote]

Forgot that part in the last message, this is of course in comm.c

Loriel 07-20-2002 09:09 AM

I believe that the block in nanny() :
[code] if ((race == 0)
   || (!race_table[race].pc_race)
|| (IS_GOOD(ch) && !race_table[race].good)
|| (IS_NEUTRAL(ch) && !race_table[race].neutral)
   || (IS_EVIL(ch) && !race_table[race].evil))

ch->race = race;
[/quote]

should be

[code] if ((race == 0)
   || (!race_table[race].pc_race)
|| (IS_GOOD(ch) && !race_table[race].good)
|| (IS_NEUTRAL(ch) && !race_table[race].neutral)
   || (IS_EVIL(ch) && !race_table[race].evil))
{
  send_to_char( "Invalid selection.\n\rEnter race name; ", ch );
  return;
}

ch->race = race;
[/quote]

melker 07-20-2002 12:04 PM

*sigh* I forgot to copy and paste that line again. I have too much commented out atm.... But those lines do not solve my problem.

Loriel 07-20-2002 12:14 PM

I don't think it's possible for anybody else to solve the problem if the code we are given to look at is not the code you are actually running.

Best of luck solving the problem on your own.

thelenian 07-20-2002 05:31 PM


melker 07-20-2002 08:29 PM

I'm sorry but I'm not gonna put up my code on the web.
Thanks for trying to assist me with my problem, even tho
we couldnt solve it this time.

thelenian 07-21-2002 08:49 AM

heh.. found the problem with the snippet I gave you..

This should work:

[code] if ((race == 0)
|| (send_to_char("Checking if(!race_table[race].pc_race...\n",ch),!race_table [race].pc_race)
|| (IS_GOOD(ch) && (send_to_char("Hey, you're good! ;D\n",ch),!race_table[race].good))
|| (IS_NEUTRAL(ch) && (send_to_char("Hey, you're neutral! ;|\n",ch),!race_table[race].neutral))
|| (IS_EVIL(ch) && (send_to_char("Hey, you're evil! Muahahaha! >;)\n",ch),!race_table[race].evil)))[/quote]

I was missing 3 sets of parenthesis.

Robbert 07-21-2002 01:38 PM

Hi Melker -

If Thelenian's latest solution doesn't work, just cut and paste those functions which are in question (the nanny, the race_table, and anything else) to a single file post the file here as a code sample. Those functions would not be enough to replicate your entire sourcecode, nor would they likely function as standalones were someone stupid enough to 'steal' them and paste them into their own source.

Along with that, would you please post a restatement of the specific problem you're having and the desired result you want to achieve. I think I'm not alone in saying that, in light of the amount of responses here, it would benefit everyone to see this reiteration.

melker 07-22-2002 01:44 PM


melker 07-22-2002 01:53 PM

My code in the nanny part in comm.c
[code]
case CON_GET_ALIGNMENT;
{
//int Race;
switch ( argument[0] )
{
case '1'; ch->alignment = 1000; break;
case '2'; ch->alignment = 750; break;
case '3'; ch->alignment = 500; break;
case '4'; ch->alignment = 250; break;
case '5'; ch->alignment = 0; break;
case '6'; ch->alignment = -250; break;
case '7'; ch->alignment = -500; break;
case '8'; ch->alignment = -750; break;
case '9'; ch->alignment = -1000; break;
default;
send_to_char("Sorry thats not a valid alignment.\n\r\n\r",ch);
// show_align(ch);
return;
}
}
write_to_buffer(d,"\n\r",0);
for ( race = 0; race < MAX_PC_RACE; race++ ) {
do_help( ch, "NANNY_RACES" );
if (IS_GOOD(ch)) {
do_help(ch,"GOOD_RACES");
write_to_buffer(d,"\n\r\n\r",1);
send_to_char( "Enter the name of your desired race; ", ch );
// Uncomment these if you use NiMUD DC(d) = CON_CHAR_GEN_RACE;
d->connected = CON_GET_NEW_RACE;
break;
}
if (IS_NEUTRAL(ch)) {
do_help(ch,"NEUTRAL_RACES");
write_to_buffer(d,"\n\r\n\r",1);
send_to_char( "Enter the name of your desired race; ", ch );
// DC(d) = CON_CHAR_GEN_RACE;
d->connected = CON_GET_NEW_RACE;
break;
}
if (IS_EVIL(ch)) {
do_help(ch,"EVIL_RACES");
write_to_buffer(d,"\n\r\n\r",1);
send_to_char( "Enter the name of your desired race; ", ch );
// DC(d) = CON_CHAR_GEN_RACE;
d->connected = CON_GET_NEW_RACE;
break;
}
}
break;
case CON_GET_NEW_RACE;
one_argument(argument,arg);


if (!strcmp(arg,"help"))
{
argument = one_argument(argument,arg);
if (argument[0] == '\0')
do_help(ch,"race help");
else
do_help(ch,argument);
write_to_buffer(d,
"What is your race (help for more information)? ",0);
break;
}

race = race_lookup(argument);

if ((race == 0)
|| (send_to_char("Checking if(!race_table[race].pc_race...\n",ch),!race_table [race].pc_race)
|| (IS_GOOD(ch) && (send_to_char("Hey, you're good! ;D\n",ch),!race_table[race].good))
|| (IS_NEUTRAL(ch) && (send_to_char("Hey, you're neutral! ;|\n",ch),!race_table[race].neutral))
|| (IS_EVIL(ch) && (send_to_char("Hey, you're evil! Muahahaha! >;)\n",ch),!race_table[race].evil)))
ch->race = race;

for (i = 0; i < MAX_STATS; i++)
ch->perm_stat[i] = pc_race_table[race].stats[i];
ch->affected_by = ch->affected_by|race_table[race].aff;
ch->shielded_by = ch->shielded_by|race_table[race].shd;
ch->imm_flags = ch->imm_flags|race_table[race].imm;
ch->res_flags = ch->res_flags|race_table[race].res;
ch->vuln_flags = ch->vuln_flags|race_table[race].vuln;
ch->form = race_table[race].form;
ch->parts = race_table[race].parts;

for (i = 0; i < 5; i++)
{
if (pc_race_table[race].skills[i] == NULL)
break;
group_add(ch,pc_race_table[race].skills[i],FALSE);
}
/* add cost */
ch->pcdata->points = pc_race_table[race].points;
ch->size = pc_race_table[race].size;

write_to_buffer( d, "What is your sex (M/F/N)? ", 0 );
d->connected = CON_GET_NEW_SEX;
break;
[/quote]

my race tables in const.c
[code]
{
"demon", "Demon",
6,
{ 200, 200, 175, 130, 200, 200, 175, 150, 175, 175, 175,
170, 170, 140, 105, 170, 170, 140, 125, 140, 140, 140 },
{ "" },
{ 77, 57, 59, 70, 71, 57, 51, 62 },
{ 84, 64, 66, 77, 88, 64, 58, 69 },
SIZE_LARGE,
FALSE, /* Alignment good */
FALSE, /* Alignment neutral */
TRUE /* Alignment evil */
},
{
"dwarf", "Dwarf",
9,
{ 175, 150, 200, 130, 175, 175, 200, 200, 175, 175, 175,
140, 125, 170, 105, 140, 140, 170, 170, 140, 140, 140 },
{ "bash" },
{ 73, 63, 74, 53, 74, 59, 83, 63 },
{ 80, 70, 81, 60, 81, 66, 90, 70 },
SIZE_MEDIUM,
TRUE, /* Alignment good */
TRUE, /* Alignment neutral */
FALSE /* Alignment evil */
},
[/quote]

[code]
{
"demon", TRUE,
0,
0,
0,
0,
RES_FIRE,
VULN_COLD,
SHD_FIRE,
A|H|M|V, A|B|C|D|E|F|G|H|I|J|K,
FALSE, /* Alignment good */
FALSE, /* Alignment neutral */
TRUE /* Alignment evil */
},

{
"dwarf", TRUE,
0,
AFF_INFRARED,
0,
0,
RES_EARTH|RES_POISON|RES_DISEASE,
VULN_WATER,
SHD_TERRA,
A|H|M|V, A|B|C|D|E|F|G|H|I|J|K,
TRUE, /*good*/
FALSE, /*neutral*/
FALSE, /*evil*/
},
[/quote]

I have this in merc.h
[code]
struct race_type
{
char * name; /* call name of the race */
bool pc_race; /* can be chosen by pcs */
long act; /* act bits for the race */
long aff; /* aff bits for the race */
long off; /* off bits for the race */
long imm; /* imm bits for the race */
long res; /* res bits for the race */
long vuln; /* vuln bits for the race */
long shd; /* shd bits for the race */
long form; /* default form flag for the race */
long parts; /* default parts for the race */
bool good;
bool neutral;
bool evil;
};


struct pc_race_type /* additional data for pc races */
{
char * name; /* MUST be in race_type */
char who_name[6];
sh_int points; /* cost in points of the race */
sh_int class_mult[MAX_CLASS]; /* exp multiplier for class, * 100 */
char * skills[5]; /* bonus skills for the race */
sh_int stats[MAX_STATS]; /* starting stats */
sh_int max_stats[MAX_STATS]; /* maximum stats */
sh_int size; /* aff bits for the race */
bool good;
bool neutral;
bool evil;
};
[/quote]

I hope this helps.

Loriel 07-22-2002 02:07 PM

No, it doesn't help much.

Yet again you are posting your code showing that you don't have the piece of code I suggested you should add back.

Every time I made the suggestion, you told us the code was really there, you'd just pasted it wrong.

Is that the case again ?

melker 07-22-2002 02:23 PM



All times are GMT -4. The time now is 03:16 AM.

Powered by vBulletin® Version 3.6.7
Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
Copyright Top Mud Sites.com 2022